Fix for Issue 16 "Wrong::Config.read_here_or_higher can't handle absolute paths"#31
Open
arild-jacobsen wants to merge 1 commit intosconover:masterfrom
Open
Fix for Issue 16 "Wrong::Config.read_here_or_higher can't handle absolute paths"#31arild-jacobsen wants to merge 1 commit intosconover:masterfrom
arild-jacobsen wants to merge 1 commit intosconover:masterfrom
Conversation
…lute paths". Checks whether path is absolute or relative simply by calling File.file? on the path.
Contributor
|
Why not just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not the most experienced Rubyist, but I've been enjoying using Wrong, and thought I'd have a go at fixing this issue since most of my hobbyprogramming is done on windows.
My approach is simply to check whether a path is absolute or relative by calling File.file? on it.