Add short-circuit return in Wrong::FailureMessage::wrap_and_indent, t…#47
Open
jonswar wants to merge 1 commit intosconover:masterfrom
Open
Add short-circuit return in Wrong::FailureMessage::wrap_and_indent, t…#47jonswar wants to merge 1 commit intosconover:masterfrom
jonswar wants to merge 1 commit intosconover:masterfrom
Conversation
…o prevent infinite loop in environments where the width of Wrong::Terminal.size is incorrectly set to 0 (or <=6)
|
Thank you for the great library and jonswar's helpful patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add short-circuit return in Wrong::FailureMessage::wrap_and_indent, to prevent infinite loop in environments where the width of Wrong::Terminal.size is incorrectly set to 0 (or <=6).
The infinite loop can be reproduced with:
Yes, most terminal widths shouldn't be set to 0, but in my case a combination of iterm + emacs caused it to be so.