Open
Conversation
MjnMixael
force-pushed
the
qtfred-error-checker
branch
from
712767d to
adff82e
Compare
MjnMixael
force-pushed
the
qtfred-error-checker
branch
from
adff82e to
5b46bf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activates and greatly enhances the error checker in QtFRED. Instead of just one popup per issue causing an annoying stream of popups this version aggregates all errors and shows them in a single dialog with various error levels. It also tries not to silently modify mission data but has a feature to automatically fix simple problems, changing unclear implicit behavior to explicit.
Part of getting this to work is silencing mission errors during parse so that QtFRED can rely on the error checker to handle that more gracefully. Error Checker here explicitly does not handle mod data related errors so those popups remain. So I've added a
QtFred_runningvariable here so that FRED2's behavior is unaffected. Once FRED2 is fully deprecated,QtFred_runningcan be merged withFred_running.I fully expect the error levels here to be adjusted either during PR review or later during testing. The idea of critical errors, warnings, potential issues, etc was unclear in the old system as it was all sorta jumbled together. The new Error Checker class here tries to unjumble it and make it much clearer to designers what needs to happen with each issue.
I think more can be done here to make this more powerful and clear, but this has grown beyond my original scope already and I think it's in a good enough place to start.