Unify objectives language in public facing places#7391
Open
MjnMixael wants to merge 8 commits intoscp-fs2open:masterfrom
Open
Unify objectives language in public facing places#7391MjnMixael wants to merge 8 commits intoscp-fs2open:masterfrom
MjnMixael wants to merge 8 commits intoscp-fs2open:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In FRED and QtFRED I noticed that the Mission Goals dialogs use the terms "goals" and "objectives" interchangeably. It's not clear why and it can cause confusion because "goals" can also refer to AI Goals. The
goalobjective of this PR is to unify around a single term to minimize confusion, which aligns with one of my coregoalsobjectives for QtFRED; making mission design more accessible.With this PR in place we have
This is almost exclusively a public facing change only; that is in editors, the Lua API, and the sexp names. Internal code such as enum & variable names, and file names should probably be changed at some point so that coder language matches user language, but that can come later and in smaller chunks. Doing that here would be an unnecessarily large PR.
This PR does add two API changes. First, there is a new
ADE_INDEXER_DEPRECATEDto match the existing versions of Func and Virtvar. I copied the methods from those directly. Second, there is a new path in missionsave.cpp that will use the old sexp string names in place of the new if we're saving in retail format. I was surprised this didn't exist before, so there may be other sexps that were renamed over the years that may benefit from this as well.