Skip to content

Support messages with new line characters#126

Open
dnlsng wants to merge 1 commit into
scrapinghub:developfrom
dnlsng:match_new_lines
Open

Support messages with new line characters#126
dnlsng wants to merge 1 commit into
scrapinghub:developfrom
dnlsng:match_new_lines

Conversation

@dnlsng
Copy link
Copy Markdown

@dnlsng dnlsng commented Jan 3, 2017

Without this change, the bot would ignore any messages with new line characters.

This is useful in the case where you would want to do something like this:

@respond_to('(.*)', re.DOTALL)

to match all text including new lines.

I can't think of a case where this would be undesirable.

Without this change, the bot would ignore any messages with new line characters.
@jtatum
Copy link
Copy Markdown
Contributor

jtatum commented Apr 8, 2017

Please add/update functional/unit tests for this behavior.

@lins05
Copy link
Copy Markdown
Collaborator

lins05 commented May 28, 2017

ping @dnlsng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants