Skip to content

Conversation

@henrikth93
Copy link
Member

@henrikth93 henrikth93 commented Apr 27, 2025

This commit will implement a dark and light theme.

This commit will change the background color of the desktop gui.

Contributor checklist


Description

This commit will change the colors of the GUI and implement a design where we use state to track which theme we should use (light or dark).

For now, it should solve:
"The background color for the GUI should be different shades of grey (Light: #CED2D9; Dark: #1E1E1E)"

Related issue

This commit will implement a dark and light theme
@github-actions
Copy link

Thank you for the pull request! ❤️

The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Desktop rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

@github-actions
Copy link

github-actions bot commented Apr 27, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks for continuing on this, @henrikth93! Can we get the license header workflow fixes that are needed? :) Happy to do a final review after that 😊

This commit will add the license header for state.rs
@andrewtavis
Copy link
Member

Could I ask you to fill out the description in the commit message @henrikth93? Would be nice to know what this is supposed to change as there are many things that it could be doing that we have listed in #23 :)

@andrewtavis
Copy link
Member

Hey @henrikth93 👋 So far I'm only seeing the header of the GUI change color, but not the actual color of the GUI itself. See below:

Light:

Screenshot 2025-05-01 at 12 48 48

Dark:

Screenshot 2025-05-01 at 12 48 21

Can we also get the color of grey that's around the Scribe key and text input to change to the same color, and then we can bring this in as a good WIP milestone towards light and dark mode? :)

@andrewtavis
Copy link
Member

Note the commit above that removed some unused imports and an unneeded mut, so you'll need to bring that down :)

@henrikth93
Copy link
Member Author

Hey @henrikth93 👋 So far I'm only seeing the header of the GUI change color, but not the actual color of the GUI itself. See below:

Light:

Screenshot 2025-05-01 at 12 48 48 Dark: Screenshot 2025-05-01 at 12 48 21 Can we also get the color of grey that's around the Scribe key and text input to change to the same color, and then we can bring this in as a good WIP milestone towards light and dark mode? :)

Strange - it looks different for me

@andrewtavis
Copy link
Member

Can you send along some screenshots of what it looks like, @henrikth93?

@henrikth93
Copy link
Member Author

Can you send along some screenshots of what it looks like, @henrikth93?

scribedesktopdark
scribedesktopguilight

@andrewtavis
Copy link
Member

How are you changing the color mode, @henrikth93? I'm switching the color mode of my computer, but maybe that's not how I'm supposed to do it?

Changes the scribe buttons to the right color.
Implement a functionality for toggling between themes, as well as detecting which theme the system is using during startup, however, it can not detect changes during runtime as of now. The scribe logo changes depending on light/dark mode, and now has the right color.
@andrewtavis
Copy link
Member

Let me know when this is ready for a review, @henrikth93 :)

Add the correct icon for the scribe button
The toggle button now exists in a flex column, and is aligned with the text input.
@henrikth93
Copy link
Member Author

@RyanPaulGannon @andrewtavis
Feel free to check my latest commit! There are still a few things missing, but I think it has improved a lot.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All's looking great here, @henrikth93! I think that it makes sense to bring this in for now and we can continue with #23 in another PR 😊 I also added screenshots of the current UI to the readme! 🎉 I'll check in in the issue post merge :)

@andrewtavis andrewtavis merged commit 6cf78a4 into scribe-org:main Jun 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants