-
Notifications
You must be signed in to change notification settings - Fork 10
Implement dark and light theme #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement dark and light theme #26
Conversation
This commit will implement a dark and light theme
Thank you for the pull request! ❤️The Scribe-Desktop team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
|
Thanks for continuing on this, @henrikth93! Can we get the license header workflow fixes that are needed? :) Happy to do a final review after that 😊 |
This commit will add the license header for state.rs
|
Could I ask you to fill out the description in the commit message @henrikth93? Would be nice to know what this is supposed to change as there are many things that it could be doing that we have listed in #23 :) |
|
Hey @henrikth93 👋 So far I'm only seeing the header of the GUI change color, but not the actual color of the GUI itself. See below: Light:
Dark:
Can we also get the color of grey that's around the Scribe key and text input to change to the same color, and then we can bring this in as a good WIP milestone towards light and dark mode? :) |
|
Note the commit above that removed some unused imports and an unneeded |
Strange - it looks different for me |
|
Can you send along some screenshots of what it looks like, @henrikth93? |
|
|
How are you changing the color mode, @henrikth93? I'm switching the color mode of my computer, but maybe that's not how I'm supposed to do it? |
Changes the scribe buttons to the right color. Implement a functionality for toggling between themes, as well as detecting which theme the system is using during startup, however, it can not detect changes during runtime as of now. The scribe logo changes depending on light/dark mode, and now has the right color.
|
Let me know when this is ready for a review, @henrikth93 :) |
Add the correct icon for the scribe button
The toggle button now exists in a flex column, and is aligned with the text input.
|
@RyanPaulGannon @andrewtavis |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All's looking great here, @henrikth93! I think that it makes sense to bring this in for now and we can continue with #23 in another PR 😊 I also added screenshots of the current UI to the readme! 🎉 I'll check in in the issue post merge :)






This commit will implement a dark and light theme.
This commit will change the background color of the desktop gui.
Contributor checklist
Description
This commit will change the colors of the GUI and implement a design where we use state to track which theme we should use (light or dark).
For now, it should solve:
"The background color for the GUI should be different shades of grey (Light: #CED2D9; Dark: #1E1E1E)"
Related issue