Fix tab bar appearance on iOS < 26 #577
Conversation
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
| didFinishLaunchingWithOptions _: [UIApplication.LaunchOptionsKey: Any]? | ||
| ) -> Bool { | ||
| // Override point for customization after application launch. | ||
| if #available(iOS 13.0, *) { |
There was a problem hiding this comment.
question: Why are we targeting iOS 13.0 for this. Shouldn't it be iOS 26?
There was a problem hiding this comment.
On iOS 26 and newer, the system already applies the correct appearance automatically, so this code effectively becomes a no-op there.
On iOS 13–18, it ensures consistent, non-transparent tab bar behavior
Scribe/AppDelegate.swift
Outdated
| if #available(iOS 13.0, *) { | ||
| let appearance = UITabBarAppearance() | ||
| appearance.configureWithOpaqueBackground() | ||
| appearance.backgroundColor = .white |
There was a problem hiding this comment.
note: For dark mode we have a different color for the tab bar. Based on the Figma designs, it should be white or black.
There was a problem hiding this comment.
Okay I'll work on that
andrewtavis
left a comment
andrewtavis
left a comment
There was a problem hiding this comment.
praise: All's working great here now, @prince-0408 😊 Thanks for the quick work and reactions to the review! :) :)
* Fix tab bar appearance on iOS < 26 * Fix tab bar appearance on iOS < 26 and adapt colors for light/dark mode * Minor comment edits --------- Co-authored-by: Andrew Tavis McAllister <[email protected]>
2 participants
Fixes #571
Updates the tab bar appearance logic in AppDelegate to ensure correct behavior on iOS versions below 26.