Skip to content

perf(mpcs): copy jagged q from committed column MLEs #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hero78119 merged 4 commits into from
Jun 8, 2026
Merged

perf(mpcs): copy jagged q from committed column MLEs #62

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03254c3
fix: align jagged q layout with committed rows
hero78119 Jun 5, 2026
1931312
fix(mpcs): compact jagged q over occupied rows
hero78119 Jun 8, 2026
ce7f94d
rollback unnessesary comments
hero78119 Jun 8, 2026
2b2c75e
rollback unnessesary change
hero78119 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions crates/mpcs/src/jagged/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,19 +279,12 @@ pub fn jagged_commit<E: ExtensionField, InnerPcs: PolynomialCommitmentScheme<E>>
// The start position in `concatenated` for this matrix's block of polynomials.
let start = cumulative_heights[poly_idx];

// Step 3: Transpose — write each column j of `rmm` (= one polynomial)
// into its corresponding contiguous slice in `concatenated`.
// Step 3: write each committed column prefix into its compact q slice.
(0..n_cols)
.into_par_iter()
.zip(concatenated[start..start + n_cells].par_chunks_mut(n_rows))
.for_each(|(j, chunk)| {
rmm.values
.iter()
.take(n_cells)
.skip(j)
.step_by(n_cols)
.zip_eq(chunk.iter_mut())
.for_each(|(v, out)| *out = *v);
chunk.copy_from_slice(&polys[poly_idx + j].get_base_field_vec()[..n_rows]);
});

poly_idx += n_cols;
Expand Down
Loading