ci: add sumcheck performance regression guard#63
Open
kunxian-xia wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sumcheck performance regressions are currently detectable only by manually running Criterion benches.
Approach
Add a PR-only GitHub Actions guard for PRs targeting
main. The workflow compares the PR base SHA against the head SHA with thesumcheckceno_batched_mainCriterion bench ontinyscale and fails when Criterion reports a regression beyond the configured noise threshold.Testing
bash -n .github/scripts/check-criterion-regression.sh.github/workflows/perf-regression.ymlas YAML.origin/mainSHA; it reported no Criterion regression.Risk / Rollout
Main risk is CI noise from benchmark variance. The guard uses a small deterministic benchmark, fixed Rayon thread count, and a 15% noise threshold; roll back by disabling or reverting the workflow if it proves flaky.
Copilot Reviewer Directive (keep this section)
When Copilot reviews this PR, apply
.github/copilot-instructions.mdstrictly.[severity] path:line (symbol)format.PR metadata: descriptionas a finding.