crates/sel4-sys: parse_xml on contents, not file#328
Merged
Conversation
nspin
requested changes
Mar 25, 2026
Turns out the XML parser, given a file handle, will read the XML byte-by-byte. When building with Cargo timings, we saw that about 0.5s is attributed to the build step of sel4-sys. When running the build script with strace we saw there was a read system call for each byte of the XML file. With this small change the build script now takes about 0.2s. Signed-off-by: Ivan Velickovic <i.velickovic@unsw.edu.au>
Ivan-Velickovic
force-pushed
the
xml_parse_contents
branch
from
43c0862 to
a31df13
Compare
nspin
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the XML parser, given a file handle, will read the XML byte-by-byte. When building with Cargo timings, we saw that about 0.5s is attributed to the build step of sel4-sys. When running the build script with strace we saw there was a read system call for each byte of the XML file. With this small change the build script now takes about 0.2s.