Add 32-bit MCS support#336
Open
dlom wants to merge 1 commit into
Open
Conversation
Add aarch32/riscv32 MCS worlds. Fix timeout fault consumed field (split high/low on 32-bit) and tcb_configure calls. Exclude spawn examples from MCS. Verified by: `make run-fast-tests` Signed-off-by: Mark Old <mold@redhat.com>
nspin
requested changes
Apr 28, 2026
Comment on lines
+64
to
+87
| sel4::sel4_cfg_if! { | ||
| if #[sel4_cfg(KERNEL_MCS)] { | ||
| child_tcb | ||
| .tcb_configure( | ||
| child_cnode, | ||
| sel4::CNodeCapData::new(0, sel4::WORD_SIZE - child_cnode_size_bits), | ||
| child_vspace, | ||
| ipc_buffer_addr as sel4::Word, | ||
| ipc_buffer_cap, | ||
| ) | ||
| .unwrap(); | ||
| } else { | ||
| child_tcb | ||
| .tcb_configure( | ||
| sel4::init_thread::slot::NULL.cptr(), | ||
| child_cnode, | ||
| sel4::CNodeCapData::new(0, sel4::WORD_SIZE - child_cnode_size_bits), | ||
| child_vspace, | ||
| ipc_buffer_addr as sel4::Word, | ||
| ipc_buffer_cap, | ||
| ) | ||
| .unwrap(); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
In hacking/nix/scope/world/instances/default.nix, you disabled this test for MCS. Is this change incomplete? If so, maybe we should leave this test with just non-MCS support.
Comment on lines
+47
to
+66
| sel4::sel4_cfg_if! { | ||
| if #[sel4_cfg(KERNEL_MCS)] { | ||
| secondary_thread_tcb.tcb_configure( | ||
| sel4::init_thread::slot::CNODE.cap(), | ||
| sel4::CNodeCapData::new(0, 0), | ||
| sel4::init_thread::slot::VSPACE.cap(), | ||
| SECONDARY_THREAD_IPC_BUFFER_FRAME.ptr() as sel4::Word, | ||
| SECONDARY_THREAD_IPC_BUFFER_FRAME.cap(bootinfo), | ||
| )?; | ||
| } else { | ||
| secondary_thread_tcb.tcb_configure( | ||
| sel4::init_thread::slot::NULL.cptr(), | ||
| sel4::init_thread::slot::CNODE.cap(), | ||
| sel4::CNodeCapData::new(0, 0), | ||
| sel4::init_thread::slot::VSPACE.cap(), | ||
| SECONDARY_THREAD_IPC_BUFFER_FRAME.ptr() as sel4::Word, | ||
| SECONDARY_THREAD_IPC_BUFFER_FRAME.cap(bootinfo), | ||
| )?; | ||
| } | ||
| } |
Member
|
Thanks for this, and apologies for the delayed review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add aarch32/riscv32 MCS worlds. Fix timeout fault consumed field (split high/low on 32-bit) and
tcb_configurecalls. Exclude spawn examples from MCS.Verified by:
make run-fast-tests