This repository was archived by the owner on Nov 27, 2024. It is now read-only.
Cppcheck #49
Open
Cppcheck #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+1 |
thefallentree
approved these changes
Jan 6, 2019
thefallentree
suggested changes
Jan 6, 2019
Contributor
thefallentree
left a comment
thefallentree
left a comment
There was a problem hiding this comment.
actually, because va2 is not va_started , so it doesn't need to be va_end-ed.
Shea690901
suggested changes
May 29, 2022
Contributor
Shea690901
left a comment
Shea690901
left a comment
There was a problem hiding this comment.
Excerpt from man va_copy:
Each invocation of va_copy() must be matched by a corresponding invocation of va_end() in the same function.
So this change is needed, but it is missing the va_end(va) for the original va_start(va)...
| if (output == 0) { | ||
| _error(telnet, __LINE__, __func__, TELNET_ENOMEM, 0, | ||
| "malloc() failed: %s", strerror(errno)); | ||
| va_end(va2); |
Contributor
There was a problem hiding this comment.
Missing va_end(va);
The same with the change further down....
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 'cppcheck' errors; add two va_end() calls on error exit.