Season object status can be overridden per season#164
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for overriding/using “season object status” scoped to a specific season, enabling season-specific behavior when an event can be interpreted in a seasonal context.
Changes:
- Extend
EventsClient#override_season_object_statusandEventsClient#use_season_object_statuswith an optionalseason:keyword argument and pass it through to the API when provided. - Add test coverage for the new
season:parameter in both the dedicated methods and the batch status-change API.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/seatsio/events.rb |
Adds optional season: parameter to season-status override/use calls and includes it in the request payload when present. |
test/events/use_season_object_status_test.rb |
Adds coverage for use_season_object_status(..., season: ...). |
test/events/override_season_object_status_test.rb |
Adds coverage for override_season_object_status(..., season: ...). |
test/events/change_object_status_in_batch_test.rb |
Adds batch-API coverage for passing :season for OVERRIDE_SEASON_STATUS and USE_SEASON_STATUS. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.