Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions indra/llfilesystem/lldiskcache.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ LLDiskCache::LLDiskCache(const std::string& cache_dir,
// WARNING: purge() is called by LLPurgeDiskCacheThread. As such it must
// NOT touch any LLDiskCache data without introducing and locking a mutex!

// Interaction through the filesystem itself should be safe. Lets say thread
// Interaction through the filesystem itself should be safe. Let's say thread
// A is accessing the cache file for reading/writing and thread B is trimming
// the cache. Lets also assume using llifstream to open a file and
// the cache. Let's also assume using llifstream to open a file and
// boost::filesystem::remove are not atomic (which will be pretty much the
// case).

Expand Down
4 changes: 2 additions & 2 deletions indra/llkdu/llimagej2ckdu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,11 @@ struct LLKDUMessageError : public LLKDUMessage
{
// According to the documentation nat found:
// http://pirlwww.lpl.arizona.edu/resources/guide/software/Kakadu/html_pages/globals__kdu$mize_errors.html
// "If a kdu_error object is destroyed, handlerflush will be called with
// "If a kdu_error object is destroyed, handler->flush will be called with
// an end_of_message argument equal to true and the process will
// subsequently be terminated through exit. The termination may be
// avoided, however, by throwing an exception from within the message
// terminating handlerflush call."
// terminating handler->flush call."
// So throwing an exception here isn't arbitrary: we MUST throw an
// exception if we want to recover from a KDU error.
// Because this confused me: the above quote specifically refers to
Expand Down
Loading