Skip to content

Conversation

@sruehl
Copy link
Contributor

@sruehl sruehl commented Nov 7, 2025

relates to #1407.

This PR adds a schema validation to the tests to spot issues with wrong schema early

@sruehl
Copy link
Contributor Author

sruehl commented Nov 7, 2025

@ccojocar can you have a look at this PR? it seems that the SARIF reports are all over the place regarding the Schema. I think the validation is vital going forward with the fixes in #1407 for example

@sruehl
Copy link
Contributor Author

sruehl commented Nov 7, 2025

one sec, I updated this to v6 validation. For some reason I picked up v5

@sruehl sruehl force-pushed the test/sarif_validation branch from 549f8db to 17699a6 Compare November 7, 2025 17:58
@sruehl sruehl force-pushed the test/sarif_validation branch from 17699a6 to 035fe95 Compare November 7, 2025 18:09
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.66%. Comparing base (1216c9b) to head (035fe95).
⚠️ Report is 128 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1417      +/-   ##
==========================================
- Coverage   68.49%   64.66%   -3.84%     
==========================================
  Files          75       76       +1     
  Lines        4384     4590     +206     
==========================================
- Hits         3003     2968      -35     
- Misses       1233     1487     +254     
+ Partials      148      135      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants