Open
Conversation
Author
|
Addressed all of the problems mentioned in the issue |
gabrielmocanu
requested changes
Apr 4, 2026
| @@ -1,3 +1,16 @@ | |||
| FROM php:7.2-apache as builder | |||
Member
There was a problem hiding this comment.
We should use alpine, no need to use apache image here since it is bigger.
| @@ -1,3 +1,16 @@ | |||
| FROM php:7.2-apache as builder | |||
|
|
|||
Member
There was a problem hiding this comment.
Add the same structure as ARG FLAG
Comment on lines
+4
to
+5
| COPY flag ./flag | ||
| COPY src/ ./src/ |
Member
There was a problem hiding this comment.
You don't need to copy the flag, copy only the file that has the flag and change it. Like flag-template.php to flag.php.
| @@ -1,20 +1,17 @@ | |||
| FILE := ../flag | |||
| FLAG := $(shell cat $(FILE)) | |||
| EXTERNAL_PORT := 8002 | |||
Member
There was a problem hiding this comment.
Lets use EXTERNAL_PORT := 30100 for this one.
| FLAG := $(shell cat $(FILE)) | ||
| EXTERNAL_PORT := 8002 | ||
| INTERNAL_PORT := 80 | ||
| NAME := sss-web-08_todo-app |
Member
There was a problem hiding this comment.
Lets name this one exotic-attacks_todo-app
| run: generate build | ||
| docker run -d -p 8002:80 --name sss-web-08_todo-app sss-web-08_todo-app | ||
| run: build | ||
| docker run -d -p $(EXTERNAL_PORT):$(INTERNAL_PORT) --name $(NAME) $(NAME) |
Member
There was a problem hiding this comment.
Suggested change
| docker run -d -p $(EXTERNAL_PORT):$(INTERNAL_PORT) --name $(NAME) $(NAME) | |
| docker run -d -p $(EXTERNAL_PORT):$(INTERNAL_PORT) --name $(NAME) -t $(NAME) |
| generate: | ||
| sed 's/__TEMPLATE__/$(FLAG)/g' ../src/flag-template.php > ../src/flag.php | ||
| build: | ||
| docker build -f Dockerfile -t $(NAME) .. |
Member
There was a problem hiding this comment.
Suggested change
| docker build -f Dockerfile -t $(NAME) .. | |
| docker build --build-arg FLAG=$(FLAG) -t $(NAME) -f Dockerfile .. |
Comment on lines
+12
to
+15
| docker stop $(NAME) | ||
|
|
||
| clean: stop | ||
| docker rm sss-web-08_todo-app | ||
| rm ../src/flag.php | ||
| docker rm $(NAME) |
Member
There was a problem hiding this comment.
Suggested change
| docker stop $(NAME) | |
| clean: stop | |
| docker rm sss-web-08_todo-app | |
| rm ../src/flag.php | |
| docker rm $(NAME) | |
| clean: stop | |
| docker rm $(NAME) | |
| docker image rm $(NAME):latest |
|
|
||
| tolerations: [] | ||
|
|
||
| affinity: {} |
poli-gosha
commented
Apr 4, 2026
Author
poli-gosha
left a comment
poli-gosha
left a comment
There was a problem hiding this comment.
Walked through all of them, hope to have solved them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes