Add a Valgrind GitHub Actions workflow #1104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilfwilson
added
the
ci
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
147ead5 to
9dca240
Compare
Collaborator
|
I'm not seeing the valgrind job actually running, is that just me? |
Collaborator
Oh right it's only triggered by changes in the kernel module, any chance you can make a white space change so we can see it failing? |
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
3 times, most recently
from
90b826c to
ac440b0
Compare
Collaborator
Author
|
@james-d-mitchell It's running! Fun times. |
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
ac440b0 to
f8b4e2c
Compare
Collaborator
Author
|
Looks like it failed after running testinstall with acting methods off... with 2834 errors 😱 |
Collaborator
Zoiks that is not a small number |
Collaborator
Author
|
Hopefully it's the same one error happening 2834 times 🤞 |
Collaborator
|
I'll have a look on Wednesday |
wilfwilson
force-pushed
the
add-valgrind-ci-workflow
branch
from
f8b4e2c to
9addd58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a copy of the file in Digraphs: thank you whoever made that!
To see that the workflow functions as expected, see here: https://github.com/wilfwilson/Semigroups/actions/runs/17740854488/job/50414239468
Note that the job fails, because Valgrind does indeed find some issues...