[UIK-4742][d3-chart] add minimalBarWidth property for Cigarette chart#2714
Open
slizhevskyv-semrush wants to merge 3 commits intorelease/v16from
Open
[UIK-4742][d3-chart] add minimalBarWidth property for Cigarette chart#2714slizhevskyv-semrush wants to merge 3 commits intorelease/v16from
slizhevskyv-semrush wants to merge 3 commits intorelease/v16from
Conversation
ilyabrower
reviewed
Feb 12, 2026
| dataDefinitions: this.getDefaultDataDefinitions(), | ||
| highlightedLine: -1, | ||
| withTrend: false, | ||
| } as State; |
Contributor
Author
There was a problem hiding this comment.
it's needed since ts initializes state as literal object with type { highlightedLine: -1,... rather than { highlightedLine: number,...}
Contributor
There was a problem hiding this comment.
this.state: State = {...}; ?
because with as solution, you can set highlightedLine: 'qwe' for example =)
Contributor
Author
There was a problem hiding this comment.
you cannot define type of the variable inside constructor like this :)
yeah, you are right, it's a bit unsafe but looks like it's the only possible solution here :D
ilyabrower
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
@semcore/d3-chart
Added
minimalBarWidthforCigarettechart.Motivation and Context
Added
minimalBarWidthproperty forCigarettechart.How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: