fix(enums): skip nested StringEnum generation#31
Merged
Conversation
kathelon
marked this pull request as ready for review
May 27, 2026 19:42
Owner
|
Fix looks correct — Two small things: Test name — Edge case — only class-nested is covered. A struct-nested test would be nice to confirm the same behavior holds there too. Neither is a blocker, worth a look while the PR is open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[StringEnum]generation for nested enums by requiring top-level enum symbols in the incremental pipelineWhy
The generator was only filtering out
privateenums. A nestedpublicenum inside a type could still enter the pipeline even though the implementation assumes top-level enums when building generated type names.Validation
dotnet test CSharpEssentials.Tests/CSharpEssentials.Tests.csproj --filter StringEnumGeneratorTestsdotnet buildFixes #5.