Navigation and design improvements #8
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a centralized configuration object for the `Servactory::Web::Engine` to manage settings such as `mount_path`, `app_name`, and URLs. - Refactored components to use `Engine.config.servactory_web` for configuration instead of global settings. - Added validations for critical configuration attributes such as `mount_path` and `app_name`. - Updated tree builders to use the new configuration structure. - Enhanced routing with a `mount_servactory_web` method for simplified inclusion in routes. - Improved maintainability and consistency across the Servactory::Web module.
- Updated version references in layout file to use `::Servactory::VERSION::STRING` for consistency. - Added a new initializer to validate `Servactory::Web` configuration after initialization. - Raised an error if the configuration is invalid, displaying all validation errors for easier debugging. - Improved maintainability by ensuring stricter validation of configuration attributes.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| module Servactory | ||
| module Web | ||
| module Routing | ||
| def mount_servactory_web(under:, at: Engine.config.servactory_web.mount_path) |
Check warning
Code scanning / Rubocop
Checks for unused method arguments. Warning
- Added `propshaft/railtie` to the spec setup to ensure full initialization for tests. - Adjusted `servactory.rb` initializer to configure `Servactory::Web::Engine`, including setting a mount path and services directory. - Rearranged `require` statements in `spec_helper.rb` for consistency. - Enhanced configuration flexibility by introducing new attributes like `mount_path` and `app_services_directory`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.