Refactor catch task executor creation to include position property#1473
Closed
matheusandre1 wants to merge 1 commit into
Closed
Refactor catch task executor creation to include position property#1473matheusandre1 wants to merge 1 commit into
matheusandre1 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix incorrect task jsonPointer/position generation for tasks executed in a try/catch (specifically, making catch-derived tasks’ positions properly relate back to the try execution), as described in issue #1472.
Changes:
- Refactors
TryExecutorcatch-task executor creation to alter how the catch task list position is constructed. - Updates
RetryTimeoutTest#testRetryDoto assert a new expected position key for the catch “do” task.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| impl/core/src/main/java/io/serverlessworkflow/impl/executors/TryExecutor.java | Changes how the catch task executor list is built (position/prefix handling). |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/RetryTimeoutTest.java | Updates expected jsonPointer for a catch “do” task completion event. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Matheus André <matheusandr2@gmail.com>
Collaborator
|
See comment on issue, closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1472