Use fixed-size span for Ed25519 pubkey conversion - #142
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
compute_x25519_pubkey()now requires a 32-byte view, so dynamic spans with the wrong size cannot reach libsodium through this API accidentallyfile server keys are parsed as fixed-size
ed25519_pubkeyvalues before conversion, rejecting oversized values that were previously accepted with trailing bytes ignoredthis intentionally changes the C++ helper signature to match the fixed-size crypto input pattern already used elsewhere in libsession
tests
./utils/format.sh verifyWARNINGS_AS_ERRORS=ON./Build/tests/testAll "[backend][session_file_server]"./Build/tests/testAll./Build/tests/testLoggingWARNINGS_AS_ERRORS=ON./Build-clang/tests/testAll "[backend][session_file_server]"./Build-clang/tests/testAll./Build-clang/tests/testLogging