fix(desktop): let the clear-all-data spinner be optional at both ends - #169
Merged
Bilb merged 1 commit intoAug 28, 2026
Merged
Conversation
`Delete account from swarm` clicks Clear and then waits on the spinner, but the work it covers restarts the app: on devnet the delete can finish before we look, and when we do catch the spinner it leaves with the window, which Playwright reports as a target-closed error rather than a hidden element. Neither is a failure of the thing under test. The appearance wait was already tolerant, so this adds the other end: `windowMayClose` treats a closed window as the loader being gone. Opt-in, since everywhere else a window disappearing mid-wait is a crash worth failing on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #166 — it does not depend on it, that is just where the stack is; rebase onto
mainif #166 lands separately.Delete account from swarmclicks Clear and then waits on the spinner, but the work it covers restarts the app. Two ways that fails, and neither is the thing under test:waitForLoadingAnimationToFinish;So the disappearance wait gets the same treatment as the appearance wait, behind an opt-in
windowMayClose: everywhere else a window vanishing mid-wait is a crash worth failing on. The spec also drops its appearance budget to 1s, since it is waiting for something that may well not exist, and clears out the commented-outsleepFor/closeit replaces.The helper's trailing timing args become an options object; no caller passed them positionally.
Typecheck and lint clean. Not run against a device — this box has no current Desktop build.