fix: register the Pro tokens the specs already use - #170
Closed
mpretty-cyro wants to merge 1 commit into
Closed
Conversation
`Enforce localized strings` compares every `tStripped` token found in the suite against a string recorded here, and reports a token with no entry as an unknown key. Ten Pro tokens reached the specs without one — the Clear All Data warning, the refund routes, and the store-provider names — so the test failed on their absence rather than on any string differing. Recording their current values is what gives them the property the other entries have: an upstream copy change becomes a failure here instead of a silent difference in what a spec asserts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce localized stringswalks everytStripped('token')in the suite and compares what the localizerreturns against a string recorded in its own switch. A token with no entry is reported as an unknown
key, which fails the test.
Ten Pro tokens had reached the specs without an entry:
proClearAllDataDevice,proClearAllDataNetwork,clearDeviceAndNetworkConfirmproRefundDescription,proImportantDescription,requestRefundpro_provider_app_store_store,pro_provider_app_store_account,pro_provider_app_store_platform,pro_provider_google_play_storeNot a string mismatch. The run printed no
expected:/but got:line at all — every failure was theabsence of an entry. This had been recorded as the app loading a string set the source disagreed with,
which sent it to the wrong place; it is our own debt from adding Pro specs.
Recording the current values gives these tokens the property the other entries have: an upstream copy
change fails here rather than quietly altering what a spec asserts.
Verified by running the spec, which needs no device: unknown keys 10 → 0,
failed→passed.