fix: prevent duplicate attachment sends - #1977
Open
Ap4sh wants to merge 1 commit into
Open
Conversation
Bilb
requested changes
Sep 1, 2026
Comment on lines
+1
to
+16
| export function createMessageSendGuard() { | ||
| let isSending = false; | ||
|
|
||
| return async (sendMessage: () => Promise<void>) => { | ||
| if (isSending) { | ||
| return; | ||
| } | ||
|
|
||
| isSending = true; | ||
| try { | ||
| await sendMessage(); | ||
| } finally { | ||
| isSending = false; | ||
| } | ||
| }; | ||
| } |
Collaborator
There was a problem hiding this comment.
The way this is setup, I think
- if a message is being sent to conversationA and takes a while,
- you switch to conversationB while the one above is still being sent,
- and try to send a message in conversationB, it wouldn't work
Contributor
Author
There was a problem hiding this comment.
good catch, the guard is now scoped per conversation so a slow send in one conversation doesn't block a send in another one
i added a regression test for that case and pnpm ready passes locally
Ap4sh
force-pushed
the
fix-prevent-duplicate-attachment-send
branch
from
September 2, 2026 11:20
ea309fb to
37bf33d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
devbranchyarn readyrun passes successfully (more about tests here)Description
Fixes #336
This picks up the approach proposed in oxen-io/session-desktop#3100, which was never merged, and adds focused regression coverage
Repeated Enter presses or send button clicks are now ignored while the current send is still processing attachments
The guard always releases after success or failure, so retrying still works
Tests:
pnpm ready