ci: run biome lint on pull requests and main - #30
Merged
Merged
Conversation
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the repo's first GitHub Actions workflow: runs
pnpm run lint(biome) on every pull request and on pushes tomain..nvmrc, pnpm version from thepackageManagerfield inpackage.json, so neither is duplicated here..tsfiles inlib/app_localization.pnpm install --frozen-lockfile, with pnpm store caching.Heads up: this check is red on
maintodaypnpm lintcurrently reports 12 errors onmainas-is, so the job will fail on this PR too. Nothing in the workflow suppresses that — the point is to surface it. Current failures:a11y/noSvgWithoutTitlecomponents/copied/, pluspages/pro.tsx:32a11y/useValidAnchorpages/pro.tsx:721security/noDangerouslySetInnerHtmlpages/donate.tsx:111(DonorBox embed)correctness/noUnreachablelib/proBackend.ts:28(deadfetchafter an earlyreturn)These need judgement rather than a blanket autofix — the icons are decorative and want
aria-hidden, not a<title>; the DonorBox embed warrants a scopedbiome-ignorewith a reason. Left for a follow-up so this PR stays reviewable.Separately,
biome.json'sfiles.includeshas no exclusion for build output, so local runs also lint.next/types/*and produce ~40 warnings from generated files. Not fixed here.