Skip to content

ci: run biome lint on pull requests and main - #30

Merged
Bilb merged 1 commit into
mainfrom
ci/lint-workflow
Aug 31, 2026
Merged

ci: run biome lint on pull requests and main#30
Bilb merged 1 commit into
mainfrom
ci/lint-workflow

Conversation

@Bilb

@Bilb Bilb commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Adds the repo's first GitHub Actions workflow: runs pnpm run lint (biome) on every pull request and on pushes to main.

  • Node version comes from .nvmrc, pnpm version from the packageManager field in package.json, so neither is duplicated here.
  • Checks out submodules recursively, since biome lints the .ts files in lib/app_localization.
  • pnpm install --frozen-lockfile, with pnpm store caching.

Heads up: this check is red on main today

pnpm lint currently reports 12 errors on main as-is, so the job will fail on this PR too. Nothing in the workflow suppresses that — the point is to surface it. Current failures:

count rule where
9 a11y/noSvgWithoutTitle 8 files in components/copied/, plus pages/pro.tsx:32
1 a11y/useValidAnchor pages/pro.tsx:721
1 security/noDangerouslySetInnerHtml pages/donate.tsx:111 (DonorBox embed)
1 correctness/noUnreachable lib/proBackend.ts:28 (dead fetch after an early return)

These need judgement rather than a blanket autofix — the icons are decorative and want aria-hidden, not a <title>; the DonorBox embed warrants a scoped biome-ignore with a reason. Left for a follow-up so this PR stays reviewable.

Separately, biome.json's files.includes has no exclusion for build output, so local runs also lint .next/types/* and produce ~40 warnings from generated files. Not fixed here.

@Bilb
Bilb merged commit 96425ff into main Aug 31, 2026
1 check failed
@Bilb
Bilb deleted the ci/lint-workflow branch August 31, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant