Skip to content

fix buggy error handling #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

fix buggy error handling #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions src/network/event.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,30 +72,38 @@ pub async fn event_runner(mut swarm: Swarm<PeerBehavior>) -> Result<(), Box<dyn
..
})
)) => {
tracing::info!(
"Got record {:?} {:?}",
std::str::from_utf8(key.as_ref())?,
std::str::from_utf8(&value)?, // TODO: #10 `BUG` error handling would break program
);
if let Ok(value) = std::str::from_utf8(&value) {
if let Ok(key) = std::str::from_utf8(key.as_ref()) {
tracing::info!(
"Got record {:?} with key {:?}",
value,
key
)
}
};
}
kad::QueryResult::GetRecord(Ok(_)) => {}
kad::QueryResult::GetRecord(Err(err)) => {
tracing::info!("Failed to get record: {err:?}");
}
kad::QueryResult::PutRecord(Ok(kad::PutRecordOk { key })) => {
tracing::info!(
"Successfully put record {:?}",
std::str::from_utf8(key.as_ref())?
);
if let Ok(key) = std::str::from_utf8(key.as_ref()) {
tracing::info!(
"Successfully put record {:?}",
key
)
}
}
kad::QueryResult::PutRecord(Err(err)) => {
tracing::info!("Failed to put record: {err:?}");
}
kad::QueryResult::StartProviding(Ok(kad::AddProviderOk { key })) => {
tracing::info!(
"Successfully put provider record {:?}",
std::str::from_utf8(key.as_ref())?
);
if let Ok(key) = std::str::from_utf8(key.as_ref()) {
tracing::info!(
"Successfully put provider record {:?}",
key
)
}
}
kad::QueryResult::StartProviding(Err(err)) => {
eprintln!("Failed to put provider record: {err:?}");
Expand Down