[CI] re-enable test_vision_openai_server_a ci

[yhyang201]

Motivation

Installed scripts/ci/ci_install_dependency.sh to keep the environment consistent with the CI.

After running this test file multiple times, no errors were observed.

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

• Format your code according to the Format code with pre-commit.
• Add unit tests according to the Run and add unit tests.
• Update documentation according to Write documentations.
• Provide accuracy and speed benchmark results according to Test the accuracy and Benchmark the speed.
• Work with maintainers to merge your PR. See the PR Merge Process

[gemini-code-assist]

Summary of Changes

Hello @yhyang201, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on re-integrating the test_vision_openai_server_a CI test into the main test execution flow, following successful local runs by the author. While re-enabled in one suite, it has been temporarily disabled in another to address a known timeout issue, which is marked for future resolution. Additionally, the test file itself has undergone minor refactoring to ensure its proper functioning.

Highlights

• Test Re-enablement: The test_vision_openai_server_a.py CI test has been re-enabled in the primary test suite (TestSRTSuite), indicating it is now considered stable after local verification.
• Temporary Test Disablement: The same test_vision_openai_server_a.py test has been temporarily commented out in another test suite (TestSRTSuiteLong), with a TODO note to address a timeout issue.
• Test File Refactoring: The test_vision_openai_server_a.py file itself received minor updates, including an openai import and explicit imports of mixin classes, along with uncommenting a cleanup del statement.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully re-enables the test_vision_openai_server_a CI test. The changes in run_suite.py correctly move the test into an active test suite. The modifications in test_vision_openai_server_a.py are necessary for the test to run, but the import statements have been left in a slightly messy state. I've provided a couple of suggestions to clean up the code for better maintainability and adherence to best practices.

[gemini-code-assist]

The wildcard import on line 10 is redundant and not good practice as it pollutes the global namespace and makes it hard to track where names are coming from. The explicit import on lines 11-18 is a good step, but it's incomplete and coexists with the wildcard import. It's better to have a single, clean, explicit import statement. The commented-out names on line 11 are actually used in this file and should be imported explicitly. I suggest combining these into a single, comprehensive import statement and removing the wildcard import and the commented-out names.

from test_vision_openai_server_common import (
    DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
    DEFAULT_URL_FOR_TEST,
    IMAGE_MAN_IRONING_URL,
    AudioOpenAITestMixin,
    CustomTestCase,
    ImageOpenAITestMixin,
    OmniOpenAITestMixin,
    TestOpenAIMLLMServerBase,
    VideoOpenAITestMixin,
    popen_launch_server,
)

[gemini-code-assist]

Since test_vision_openai_server_a.py is now included in the per-commit-1-gpu test suite, this line in the __not_in_ci__ list is no longer necessary. For better code clarity, it's best to remove this line entirely rather than commenting it out. Additionally, the TODO: Fix timeout comment seems to be obsolete given the context of this pull request, which re-enables the test.

[Fridge003]

Failed tests are unrelated