Skip to content

Conversation

@hnyls2002
Copy link
Collaborator

@hnyls2002 hnyls2002 commented Nov 17, 2025

Some tests are never triggered by any official CI runners. Move them into the manual folder.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to streamline the continuous integration process by reorganizing test files. It moves tests that are not part of the automated CI pipeline into a dedicated 'manual' folder, ensuring that the primary CI runs focus only on relevant, automatically executed tests. Additionally, one specific backend test file has been removed, further refining the test suite.

Highlights

  • CI Refactoring: This pull request is part of a larger CI refactoring effort, specifically focusing on organizing test files.
  • Test File Relocation: Several test files previously located in test/lang/ have been moved to a new test/manual/lang_frontend/ directory. This change segregates tests that are not automatically triggered by official CI runners.
  • Test File Removal: The test/lang/test_litellm_backend.py file, which contained tests for the LiteLLM backend, has been entirely removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hnyls2002 hnyls2002 removed the run-ci label Nov 17, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the CI configuration by moving several manually triggered tests into a manual directory, which aligns with the stated goal. My primary feedback concerns the deletion of test/lang/test_litellm_backend.py. While other tests are moved, this one is removed entirely. It's unclear if this is intentional. If the test is obsolete, it would be beneficial to mention this in the description for clarity. Otherwise, it might need to be moved like the other files.

@github-actions github-actions bot added documentation Improvements or additions to documentation Multi-modal multi-modal language model labels Nov 17, 2025
@github-actions github-actions bot added the npu label Nov 19, 2025
@hnyls2002
Copy link
Collaborator Author

/tag-and-rerun-ci

@hnyls2002 hnyls2002 merged commit 196b940 into main Nov 19, 2025
64 of 80 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/move-manual-tests branch November 19, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Multi-modal multi-modal language model npu run-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants