-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[3/N] CI refactor: move some manually triggered tests. #13448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to streamline the continuous integration process by reorganizing test files. It moves tests that are not part of the automated CI pipeline into a dedicated 'manual' folder, ensuring that the primary CI runs focus only on relevant, automatically executed tests. Additionally, one specific backend test file has been removed, further refining the test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the CI configuration by moving several manually triggered tests into a manual directory, which aligns with the stated goal. My primary feedback concerns the deletion of test/lang/test_litellm_backend.py. While other tests are moved, this one is removed entirely. It's unclear if this is intentional. If the test is obsolete, it would be beneficial to mention this in the description for clarity. Otherwise, it might need to be moved like the other files.
|
/tag-and-rerun-ci |
Some tests are never triggered by any official CI runners. Move them into the
manualfolder.