changed capitalization of predicates used as link relations#61
Open
elf-pavlik wants to merge 1 commit intoshapetrees:mainfrom
Open
changed capitalization of predicates used as link relations#61elf-pavlik wants to merge 1 commit intoshapetrees:mainfrom
elf-pavlik wants to merge 1 commit intoshapetrees:mainfrom
Conversation
elf-pavlik
commented
Aug 3, 2021
| [=shape tree instance=] including: | ||
| * An HTTP `Link` header with the relation of | ||
| `http://shapetrees.org/#TargetShapeTree` if `SHAPETREEURI` is provided | ||
| `http://shapetrees.org/#targetShapeTree` if `SHAPETREEURI` is provided |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| `http://shapetrees.org/#targetShapeTree` if `SHAPETREEURI` is provided | |
| `http://www.w3.org/ns/shapetrees#targetShapeTree` if `SHAPETREEURI` is provided |
elf-pavlik
commented
Aug 3, 2021
| `http://shapetrees.org/#targetShapeTree` if `SHAPETREEURI` is provided | ||
| * An HTTP `Link` header with the relation of | ||
| `http://shapetrees.org/#FocusNode` if `FNURI` is provided | ||
| `http://shapetrees.org/#focusNode` if `FNURI` is provided |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| `http://shapetrees.org/#focusNode` if `FNURI` is provided | |
| `http://www.w3.org/ns/shapetrees#focusNode` if `FNURI` is provided |
elf-pavlik
commented
Aug 3, 2021
| 1. If `PCST` exists | ||
| 1. Let `TST` be the target [=shape tree=] URI from an HTTP `Link` header with a | ||
| relation of `http://shapetrees.org/#TargetShapeTree` | ||
| relation of `http://shapetrees.org/#targetShapeTree` |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| relation of `http://shapetrees.org/#targetShapeTree` | |
| relation of `http://www.w3.org/ns/shapetrees#targetShapeTree` |
elf-pavlik
commented
Aug 3, 2021
| relation of `http://shapetrees.org/#targetShapeTree` | ||
| 1. Let `FN` be a focus node URI from an HTTP `Link` header with a relation of | ||
| `http://shapetrees.org/#FocusNode` | ||
| `http://shapetrees.org/#focusNode` |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| `http://shapetrees.org/#focusNode` | |
| `http://www.w3.org/ns/shapetrees#focusNode` |
Contributor
Author
|
I added inline suggestions to use the same namespace as rest of the vocabulary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traditionally predicates start with lowercase letter. IMO anything used as link relation can be considered a predicate.