refactor(buildrun): implement Template Method pattern for TaskRun and PipelineRun generation #2056
+1,409
−656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
release-note
pull-request-size
bot
added
the
size/XXL
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
4 times, most recently
from
1ca78ca to
e837e32
Compare
openshift-merge-robot
added
the
needs-rebase
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
from
e837e32 to
1b53dab
Compare
openshift-merge-robot
removed
the
needs-rebase
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
from
1b53dab to
c1fac02
Compare
adambkaplan
reviewed
Dec 2, 2025
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
from
a2eea40 to
d162766
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
2 times, most recently
from
69527a0 to
b6db4c5
Compare
openshift-ci
bot
added
do-not-merge/release-note-label-needed
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
from
7794b28 to
c90dbed
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
from
c90dbed to
c853cb2
Compare
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
2 times, most recently
from
ecae202 to
179c370
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Member
Author
|
/retest Release Note Linter |
Contributor
|
@ayushsatyam146: No presubmit jobs available for shipwright-io/build@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/retest |
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
from
179c370 to
508aebe
Compare
openshift-ci
bot
added
release-note
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
2 times, most recently
from
a001dfb to
fdcf4b7
Compare
Member
Author
|
/retest Unit, Integration, and E2E Tests / e2e (v1.34.0, v1.6.0) |
Contributor
|
@ayushsatyam146: No presubmit jobs available for shipwright-io/build@main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Member
Author
|
/retest |
…late Method pattern
# Summary
Introduced a common BuildRunExecutorGenerator interface that both TaskRun and
PipelineRun implementations follow, while maintaining clear separation between
execution models.
# Changes
- Created executor_generator.go defining 5-phase build execution interface with
initialization step
- Implemented TaskRunGenerator for single-pod, sequential step execution
- Implemented PipelineRunGenerator for multi-pod, multi-task execution with
PVC-based data sharing
- Shipwright-managed push strategies are now supported in PipelineRun mode via
a separate output-image task, enabling 3-task execution (source-acquisition,
build-strategy, output-image) when using shp-output-directory. Strategy-managed
push continues to use 2 tasks.
# Architecture overview:
TaskRun: 1 Pod → [git-clone, buildah-build, image-processing]
PipelineRun: 2-3 Pods → Task1[git-clone] → Task2[buildah-build] → Task3[image-processing]*
(*Task3 only created for shipwright-managed push strategies)
The unified approach enables easy addition of new executor types (e.g., for
multi-arch builds) while maintaining a single source of truth for business logic.
[Release Notes]
- Added PipelineRun execution mode as an alternative to TaskRun, enabling
multi-pod build execution with persistent workspace storage. This lays
the foundation for future multi-architecture build support.
- Build executions now support two modes:
- TaskRun mode (default): Single pod with sequential steps, EmptyDir storage
- PipelineRun mode: Multiple pods (2-3 depending on push strategy) with
task-level separation and PVC-based data sharing
- Note: PipelineRun mode uses PersistentVolumeClaim (1Gi) for workspace
storage instead of EmptyDir, which may require StorageClass configuration
in your cluster.
Signed-off-by: ayushsatyam146 <[email protected]>
ayushsatyam146
force-pushed
the
split-pipeline-implementation
branch
from
fdcf4b7 to
2eabc49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
initialization step
PVC-based data sharing
a separate output-image task, enabling 3-task execution (source-acquisition,
build-strategy, output-image) when using shp-output-directory. Strategy-managed
push continues to use 2 tasks.
Summary
Introduced a common BuildRunExecutorGenerator interface that both TaskRun and
PipelineRun implementations follow, while maintaining clear separation between
execution models.
Architecture overview:
The unified approach enables easy addition of new executor types (e.g., for
multi-arch builds) while maintaining a single source of truth for business logic.
Release Notes