amyboardweb: skip green-button gate on save's internal zA+zD pull#914
Merged
Conversation
When the user clicks "Write sketch and knobs to AMYboard" in control mode, save() runs an internal sync_amy_state pull (zA+zD) before the zB reboot + upload. That internal pull is implicit — the user already clicked Save — so re-prompting them with the green Pull from AMYboard button is just extra clicks. Set _skip_pull_gate before the pull so the modal goes straight to busy state. The subsequent zB-reboot modal still gates so the user confirms MIDI ports before the actual upload. Net: save flow now requires one click (Save itself) plus one green button click (for the upload), down from three. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_skip_pull_gatebeforesync_amy_state_async()so the modal goes straight to busy state for the internal pullSave flow now: 1 click on Save + 1 click on the green button (for upload), down from 3.
Test plan
🤖 Generated with Claude Code