amyboard: spawn i2c_check_for_data task so I2C follower input works#917
Merged
Conversation
i2c_follower_init() configures the I2C slave hardware on address 0x3F, and i2c_check_for_data() polls the slave buffer and feeds incoming packets to amy_add_message(). But the FreeRTOS task running i2c_check_for_data() was never created, so bytes received over I2C sat in the driver buffer and never reached AMY. Add the missing xTaskCreatePinnedToCore() call right after i2c_follower_init() in app_main(), using the existing i2c_check_for_data_handle declared in amyboard_support.c. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i2c_follower_init()sets up the amyboard's I2C slave hardware on address0x3F, andi2c_check_for_data()is the polling loop that reads incoming I2C packets and feeds them toamy_add_message(). But the FreeRTOS task to runi2c_check_for_data()was never created — so bytes sent to the amyboard over I2C piled up in the driver buffer and never reached AMY. This explains user reports that the docs example (Tulip CC → amyboard I2C follower port → AMY playback) stopped working.xTaskCreatePinnedToCore()call right afteri2c_follower_init()inapp_main(), using the existingi2c_check_for_data_handlealready declared inamyboard_support.c.tulip/amyboard/main.c.Test plan
idf.py -DMICROPY_BOARD=AMYBOARD buildsucceeds cleanly.docs/amyboard/README.md.🤖 Generated with Claude Code