color theme quick change setting #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
thank you it looks like a great project, I use hledger all the time, let me know if I would be welcome to contribute or if there is a style guide or master plan or something. |
Owner
|
Contributions are most welcome!
I had created the framework to easily change themes and add new ones but I
never got around to finishing it.
I'm on vacation at the moment, I will review the PR next week.
…On Tue, 12 Aug 2025 at 1:59 AM, Abu-Daud ***@***.***> wrote:
*Abu-Daud* left a comment (siddhantac/puffin#70)
<#70 (comment)>
thank you it looks like a great project, I use hledger all the time, let
me know if I would be welcome to contribute or if there is a style guide or
master plan or something.
—
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZLD7LLYDP26FFOLO2TNLD3NEN6JAVCNFSM6AAAAACDUXQ4JCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCNZXGEZTENBYHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Features added: - Register-specific filter input box (Ctrl+F or /) for filtering like 'hledger reg rent' - Alternating light and lighter green rows for classic printed ledger appearance - Sky blue highlight color across all themes replacing previous pink highlights - Dynamic help text and keyboard navigation for filter controls - Smart filtering that works with existing global filters UI improvements: - Custom register table renderer with alternating green backgrounds - Filter input box with contextual help at top of register tables - Consistent sky blue selection highlighting across all UI elements - Enhanced help system documenting new register filter functionality Technical changes: - Added register filter textinput to Table struct for register-specific filtering - Modified refresh logic to prioritize register filters over global description filter - Added light/lighter green color palette to gruvbox colorscheme - Updated theme accent colors from pink to sky blue for all themes - Enhanced table rendering with proper scrolling and alternating row colors
- Switch to dark text (#2d3748) on light green backgrounds for better readability - Update filter box and help text to use dark text on light backgrounds - Change all borders to light gray (#cbd5e0) for cleaner appearance - Add light background (#f7fafc) to headers and filter box - Keep sky blue selection highlighting with white text for contrast - Maintain alternating light/lighter green rows while fixing text visibility This resolves readability issues with the previous light-on-light text rendering and provides a proper light theme appearance for the register tables.
- Reduce date column width from 25% to 8% of table width - Allocate more space to description (50%) for better readability - Apply minimal left padding (PaddingLeft(0)) to date column and header - Reduce first column width by 2 chars to move content closer to left edge - Maintain minimum width of 6 characters for date display - Keep alternating green backgrounds and light theme styling This provides better space utilization with dates positioned just 2 characters from the table's left edge while giving more room for transaction descriptions.
- Add WARP.md documentation for development guidance - Implement graph view functionality - Update configuration files for better debugging - Enhance table styling and layout - Improve settings view and model handling - Add audio test files for future features
- Add emacs/puffin/ with puffin.el entry and supporting modules - Async runner stub for MELPA readiness; compiles cleanly - Faces, UI, filters, reports rendering, and README - License headers and metadata for MELPA
Owner
|
Hi, sorry for the delay. Can you explain the changes? Why are there binary files? Why are there changes to keybindings and navigation? Looks like a lot of unrelated changes have been committed which have nothing to do with changing the color to blue? |
…; forward keys to table model Also includes current graph BS charts edits on this branch.
…alance columns (add liabilities date columns)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hated the pink highlight and wanted to change it to blue.