[codex] Fix native Windows recording pause#639
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds pause/resume functionality to Windows native screen recording across renderer APIs, React hooks, main-process IPC with cursor pause telemetry, native audio mixer pause gating, WGC capture synchronization, and Windows build helper updates. ChangesNative Windows Recording Pause/Resume
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f9ea0b2 to
ca826d9
Compare
…sed-recording # Conflicts: # src/hooks/useScreenRecorder.ts
siddharthvaddem
left a comment
There was a problem hiding this comment.
LGTM — conflict resolved, lint/typecheck/tests green locally.
Summary
Adds pause/resume support for native Windows WGC recording so the existing recording pause control works when the app uses the Windows native helper.
What changed
pauseandresumecommands, suspend video/audio output while paused, and compact encoded timestamps after resume.um/x64libraries before local compatibility libs socursor-samplerlinks correctly on native Windows dev environments.Validation
npm run build-vitenpm run build:native:winnpx biome check electron/electron-env.d.ts electron/ipc/handlers.ts electron/preload.ts src/hooks/useScreenRecorder.ts scripts/build-windows-wgc-helper.mjsSummary by CodeRabbit
New Features
Improvements
Bug Fixes