Conversation
Fixes #12924 Fixes #12925 Fixes #12926 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
There was a problem hiding this comment.
Pull request overview
Expands Talos v1.13 documentation by adding new networking “Advanced Configuration” pages and introducing a new Kubernetes guide entry for Flannel, while updating existing KubeSpan docs to use the v1.13 config document format.
Changes:
- Add new Talos v1.13 networking docs pages: Blackhole Routes, Routing Rules, and VRF.
- Update KubeSpan docs examples to use
KubeSpanConfigdocuments instead of.machine.network.kubespan. - Add a new Kubernetes guides CNI page for Flannel and wire it into navigation (YAML + generated
docs.json).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
talos-v1.13.yaml |
Adds new advanced networking pages to the v1.13 navigation. |
public/talos/v1.13/networking/kubespan.mdx |
Updates configuration examples to the v1.13 KubeSpanConfig document format. |
public/talos/v1.13/networking/advanced/vrf.mdx |
New VRF how-to page (contains an inaccurate “bond” reference). |
public/talos/v1.13/networking/advanced/routing-rules.mdx |
New routing rules how-to page (contains incorrect priority/reserved range details). |
public/talos/v1.13/networking/advanced/blackhole.mdx |
New blackhole routes how-to page. |
public/kubernetes-guides/cni/flannel.mdx |
New Flannel guide page (currently has a typo and placeholder/TBD content). |
public/docs.json |
Updates generated navigation to include the new pages. |
kubernetes-guides.yaml |
Adds Flannel to Kubernetes Guides → CNI navigation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --- | ||
|
|
||
| [Flannel](https://github.com/flannel-io/flannel) is a popular Container Network Interface (CNI) plugin that provides a simple and efficient way to create an overlay network for Kubernetes clusters. | ||
| Flannel is a default CNI provided by Talos Linux, and it can be overridden with other CNI implenmentations if desired (e.g. [Cilium](./deploying-cilium), [Calico](./deploy-calico), etc.). |
There was a problem hiding this comment.
Typo: "implenmentations" should be "implementations".
| Flannel is a default CNI provided by Talos Linux, and it can be overridden with other CNI implenmentations if desired (e.g. [Cilium](./deploying-cilium), [Calico](./deploy-calico), etc.). | |
| Flannel is a default CNI provided by Talos Linux, and it can be overridden with other CNI implementations if desired (e.g. [Cilium](./deploying-cilium), [Calico](./deploy-calico), etc.). |
|
|
||
| Starting with Talos 1.13, TBD. |
There was a problem hiding this comment.
This page is linked from navigation/docs.json but the content ends with "Starting with Talos 1.13, TBD."; please replace the placeholder with actual guidance (or remove the page from navigation until it’s complete).
| Starting with Talos 1.13, TBD. |
| The priority is a number between 0 and 32766, where 0 is the highest priority and 32766 is the lowest priority. | ||
| Priorities 0, 32765, and 32766 are reserved for special use by the system. |
There was a problem hiding this comment.
The description of reserved/valid routing rule priorities here doesn’t match the RoutingRuleConfig reference (priority must be 1..32765, excluding reserved priorities 0, 32500, 32501, 32766, 32767). Please update the stated range and reserved values accordingly.
| The priority is a number between 0 and 32766, where 0 is the highest priority and 32766 is the lowest priority. | |
| Priorities 0, 32765, and 32766 are reserved for special use by the system. | |
| The priority must be a number between 1 and 32765. | |
| Priorities 0, 32500, 32501, 32766, and 32767 are reserved for special use by the system and cannot be used for custom routing rules. |
|
|
||
| Addresses and routes can be configured in the same document as shown in [static link configuration](./../configuration/static). | ||
|
|
||
| The `links` field specifies the physical interfaces that are part of the bond, and [link aliases](./../configuration/aliases) can be used here as well. |
There was a problem hiding this comment.
This line appears to be copied from bond docs: in VRFConfig, links are interfaces assigned to the VRF, not "part of the bond". Please update the wording to describe VRF semantics (and keep the link-alias note if desired).
| The `links` field specifies the physical interfaces that are part of the bond, and [link aliases](./../configuration/aliases) can be used here as well. | |
| The `links` field specifies the interfaces assigned to the VRF, and [link aliases](./../configuration/aliases) can be used here as well. |
| @@ -110,23 +106,27 @@ cluster: | |||
| kubernetes: # Kubernetes registry is problematic with KubeSpan, if the control plane endpoint is routeable itself via KubeSpan. | |||
There was a problem hiding this comment.
Typo in comment: "routeable" -> "routable".
| kubernetes: # Kubernetes registry is problematic with KubeSpan, if the control plane endpoint is routeable itself via KubeSpan. | |
| kubernetes: # Kubernetes registry is problematic with KubeSpan, if the control plane endpoint is routable itself via KubeSpan. |
Fixes siderolabs/talos#12924
Fixes siderolabs/talos#12925
Fixes siderolabs/talos#12926