Open
Conversation
pmcollins
reviewed
Jan 26, 2026
Contributor
pmcollins
left a comment
There was a problem hiding this comment.
Hi Siim! This is great. Added some comments.
pmcollins
reviewed
Feb 23, 2026
Contributor
pmcollins
left a comment
There was a problem hiding this comment.
Just a nit and a question about shutdown.
Comment on lines
+30
to
+33
| if not parent_span.is_valid: | ||
| return True | ||
|
|
||
| return parent_span.is_remote |
Contributor
There was a problem hiding this comment.
For clarity, what do you think about this instead:
is_root_span = not parent_span.is_valid
return is_root_span or parent_span.is_remote
| self._profiler.pause_after(60.0) | ||
|
|
||
| def shutdown(self) -> None: | ||
| pass |
Contributor
There was a problem hiding this comment.
Should the profiler be shut down here?
pmcollins
approved these changes
Feb 23, 2026
Contributor
pmcollins
left a comment
There was a problem hiding this comment.
LGTM. Maybe the shutdown thing is not an issue because it's generally called atexit when the profiler thread will be shutdown anyway. The other comment is just about readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New environment variables:
SPLUNK_SNAPSHOT_PROFILER_ENABLEDdefault:falseSPLUNK_SNAPSHOT_SELECTION_PROBABILITYdefault:0.01SPLUNK_SNAPSHOT_SAMPLING_INTERVALdefault:10(milliseconds)The profiling is triggered in
CallgraphsSpanProcessorwhich filters the stacktraces based on active traces (i.e. it only keeps stacktraces matching a trace that has been selected for profiling).Changes to profiling:
profiling.instrumentation.sourceattribute.time.monotonicinstead oftime.timefor consistent sleeping.start. This is used for callgraphs when no traces have been selected for a minute.