Skip to content

Update dependencies - #89

Merged
dknopik merged 23 commits into
sigp:masterfrom
ackintosh:update-deps
Sep 22, 2026
Merged

dknopik merged 23 commits into
sigp:masterfrom
ackintosh:update-deps

Conversation

@ackintosh

@ackintosh ackintosh commented Sep 9, 2025 •

Copy link
Copy Markdown
Member

This PR closes #88

Dependency updates

crate before after
rand 0.8 0.10
sha3 0.10 0.11
k256 0.13 0.14
ed25519-dalek 2.1 3.0
secp256k1 0.30 0.31

Breaking changes

This needs a new minor release.

  • CombinedKey variants expose k256::ecdsa::SigningKey and ed25519::SigningKey directly, and EnrKey is only implemented for the new versions. Downstream creates that depend on k256 / ed25519-dalek directly must upgrade, or the key types will no longer unify.

@AgeManning

Copy link
Copy Markdown
Member

Thanks @ackintosh - Still need to sort out CI tho

@ackintosh

Copy link
Copy Markdown
Member Author

The dependencies have been bumped, but some of them are still pre-release (or RC) versions. It's better to wait for the stable release.

the trait `DerefMut` is not implemented for `OsRng`
`thread_rng` is deprecated since 0.9.0: Renamed to `rng`
`try_sign_digest_with_rng` and `verify_digest` have been updated in
RustCrypto/signatures#1064
  error[E0599]: the method `fill_bytes` exists for struct `rand::rngs::OsRng`, but its trait bounds were not satisfied
    --> src/keys/rust_secp256k1.rs:27:19
     |
  27 |             OsRng.fill_bytes(&mut noncedata);
     |                   ^^^^^^^^^^
     |
    ::: /Users/akihito/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/rand_core-0.9.3/src/os.rs:47:1
     |
  47 | pub struct OsRng;
     | ---------------- doesn't satisfy `rand::rngs::OsRng: rand::RngCore`, `rand::rngs::OsRng: std::ops::DerefMut` or `rand::rngs::OsRng: std::ops::Deref`
     |
     = note: the following trait bounds were not satisfied:
             `rand::rngs::OsRng: std::ops::DerefMut`
             which is required by `rand::rngs::OsRng: rand::RngCore`
             `rand::rngs::OsRng: std::ops::Deref`
             which is required by `rand::rngs::OsRng: rand::RngCore`
since the first argument type has been changed from `&Message` to `impl Into<Message>`.
rust-bitcoin/rust-secp256k1@ec0a69f
warning: passing a unit value to a function
 warning: called `unwrap` on `build` after checking its variant with `is_none`
 help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#unnecessary_unwrap

@ackintosh ackintosh left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left comments explaining why each of these changes was needed due to the dependency updates.

Comment thread src/keys/combined.rs Resolved
Comment thread src/keys/k256_key.rs Resolved
Comment thread src/keys/combined.rs Resolved
Comment thread src/keys/k256_key.rs Resolved
Comment thread src/keys/k256_key.rs Resolved
@ackintosh
ackintosh marked this pull request as ready for review August 15, 2026 22:03

@jxs jxs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akihito LGTM

Comment thread README.md Resolved
@dknopik
dknopik merged commit 509667f into sigp:master Sep 22, 2026
9 checks passed
@ackintosh
ackintosh deleted the update-deps branch September 23, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update secp256k1 to 0.31 and rand 0.9

4 participants