Change default signature filename to claims.jsonl#591
Open
ralphbean wants to merge 2 commits intosigstore:mainfrom
Open
Change default signature filename to claims.jsonl#591ralphbean wants to merge 2 commits intosigstore:mainfrom
ralphbean wants to merge 2 commits intosigstore:mainfrom
Conversation
This aligns with the OMS format conventions where claims.jsonl is the standard filename for bundled attestations. The default can still be overridden using the --signature CLI option. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
Updated all examples in README.md, docs/demo.ipynb, and docs/model_signing_format.md to reflect the new default signature filename. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
ralphbean
force-pushed
the
change-default-signature-filename
branch
from
c77fcc1 to
11ed8c3
Compare
Member
mihaimaruseac
left a comment
mihaimaruseac
left a comment
There was a problem hiding this comment.
I think that for a period we should support both model.sig (with just the signature) and claims.jsonl (which can contain anything).
More important though, I think we should signal in README and everywhere else that claims.jsonl is appended to (#592 is a step in that direction, but verification should still iterate over all claims to find which one can be verified rather than just the last?)
I'll look more over these over the break / in the new year.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the default signature filename from
model.sigtoclaims.jsonlto align with OMS format conventions whereclaims.jsonlis the standard filename for bundled attestations from #587.Changes
model.sigtoclaims.jsonl--signatureCLI optionRelated to #587