-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add Python 3.13 support, remove Python 3.9 support #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Enkidu93
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Enkidu93 reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @pmachapman).
pyproject.toml line 87 at r1 (raw file):
jupyter = "^1.0.0" pandas = "^2.0.3" pyright = { extras = ["nodejs"], version = "^1.1.400" }
Why did we need the nodejs extra previously? 🤔
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 352 352
Lines 22337 22337
=======================================
Hits 20270 20270
Misses 2067 2067 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pmachapman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pmachapman made 1 comment.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @Enkidu93).
pyproject.toml line 87 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
Why did we need the
nodejsextra previously? 🤔
Turns out I used the wrong poetry command to update pyright. I was meant to include [nodejs] at the end, as pyright requires nodejs.
ddaspit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ddaspit reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93).
Fixes #243
This change is