Add Future completion subscriptions - #1
Closed
simPod wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Superseded by upstream PR amphp#469. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Promise adapters may need to observe a Future completion without transforming it into another Future.
Decision
Add
Future::subscribe()andFuture::unsubscribe()as public facades for the existing one-shot completion callback mechanism.Consequences
Adapters can observe values and errors without allocating derived Future chains. Callback subscriptions can be removed before a Future completes.
Benchmark Context
A wide asynchronous result graph with 838 parent objects and three Future-backed fields measured the cost of moving from Fiber-per-continuation handling to direct callback composition:
That workload reduced CPU time by about 19% and peak memory by about 46%. These measurements provide motivation for a public completion subscription API; they are not a general performance guarantee.