Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
==========================================
- Coverage 95.33% 95.31% -0.02%
==========================================
Files 9 9
Lines 3255 3311 +56
==========================================
+ Hits 3103 3156 +53
- Misses 152 155 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
simonw
commented
Jun 21, 2026
Comment on lines
+620
to
634
| def _executescript(self, sql: str) -> sqlite3.Cursor: | ||
| if self.conn.in_transaction: | ||
| cursor = self.conn.cursor() | ||
| statement = [] | ||
| for char in sql: | ||
| statement.append(char) | ||
| statement_sql = "".join(statement).strip() | ||
| if statement_sql and sqlite3.complete_statement(statement_sql): | ||
| cursor.execute(statement_sql) | ||
| statement = [] | ||
| statement_sql = "".join(statement).strip() | ||
| if statement_sql: | ||
| cursor.execute(statement_sql) | ||
| return cursor | ||
| return self.conn.executescript(sql) |
Owner
Author
There was a problem hiding this comment.
This is the workaround for the problem described here:
To make it clearer why we are avoiding executescript()
Owner
Author
|
I'm testing this branch against various existing projects using this pattern: Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs:
📚 Documentation preview 📚: https://sqlite-utils--757.org.readthedocs.build/en/757/