Repository navigation
Fix TreeMesh average_cell_to_face for cells spanning the whole mesh - #421
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 86.84% 86.86% +0.02%
==========================================
Files 93 93
Lines 19208 19239 +31
Branches 2152 2154 +2
==========================================
+ Hits 16681 16712 +31
Misses 1840 1840
Partials 687 687 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
In average_cell_to_face_x, _y and _z, the branch for a cell with no neighbor on the high side ends with `continue`, so for a cell with no neighbor on either side (one that spans the whole mesh in that direction) the low-side boundary face was never filled. Those rows of the operator were empty, so the low-side boundary faces of such cells got no value. Handle the low-side boundary face first, so the high-side branch can no longer skip it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jcapriot
force-pushed
the
fix_tree_boundary_face_averaging
branch
from
September 30, 2026 14:52
fb0efe2 to
4caf405
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
average_cell_to_face_x,_yand_z, the branch for a cell with no neighbor on the high side ends withcontinue, so for a cell with no neighbor on either side (one that spans the whole mesh in that direction) the low-side boundary face was never filled. Those rows of the operator were empty, so the low-side boundary faces of such cells got no value.This fixes it by handling the low-side boundary face first, so the high-side branch can no longer skip it.