Skip to content

Fix pr 3222 backward compat - #3233

Closed
yaotukeji wants to merge 2 commits into
sipeed:mainfrom
yaotukeji:fix-pr-3222-backward-compat
Closed

Fix pr 3222 backward compat#3233
yaotukeji wants to merge 2 commits into
sipeed:mainfrom
yaotukeji:fix-pr-3222-backward-compat

Conversation

@yaotukeji

Copy link
Copy Markdown

📝 Description

🗣️ Type of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📖 Documentation update
  • ⚡ Code refactoring (no functional changes, no api changes)

🤖 AI Code Generation

  • 🤖 Fully AI-generated (100% AI, 0% Human)
  • 🛠️ Mostly AI-generated (AI draft, Human verified/modified)
  • 👨‍💻 Mostly Human-written (Human lead, AI assisted or none)

🔗 Related Issue

📚 Technical Context (Skip for Docs)

  • Reference URL:
  • Reasoning:

🧪 Test Environment

  • Hardware:
  • OS:
  • Model/Provider:
  • Channels:

📸 Evidence (Optional)

Click to view Logs/Screenshots

☑️ Checklist

  • My code/docs follow the style of this project.
  • I have performed a self-review of my own changes.
  • I have updated the documentation accordingly.

radare and others added 2 commits July 3, 2026 18:30
- Drop legacy features, no fallbacks and outdated tests
- Reference official relay list website instead of harcoded copy
- Drop password-based email configuration, secrets must live in the jsonrpc
- Rename `invite_link` → `join_invite_link` and add `show_invite_link`
- Add full deltachat section to config.example.json
- Update defaults to include all settings keys with zero values
- Update documentation to reflect the simplified chatmail-only setup
- Add deprecated invite_link field as alias for join_invite_link
- Restore password, imap_*, smtp_* fields with deprecation warnings
- Implement MigrateLegacyFields() for automatic migration
- Add migration call in LoadConfig() after channel initialization
- Ensure show_invite_link defaults to true for existing configs

This fixes the breaking changes introduced in PR sipeed#3222 while maintaining
the cleanup goals. Users with legacy configurations will see warnings
but their setups will continue to work.

Fixes backward compatibility issues reported in PR sipeed#3222 comments:
- Broken legacy Delta Chat flow with password auth
- Missing invite_link → join_invite_link migration
- show_invite_link default value not inherited

🤖 Generated with AI assistance, reviewed by human
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ yaotukeji
❌ radare
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

Copy link
Copy Markdown

This PR has had no activity for 7 days and has been marked as stale. If you are still working on it, please push an update or leave a comment; otherwise it will be closed automatically in 7 days.

@github-actions

Copy link
Copy Markdown

This PR has been closed after 14 days of inactivity. If you would like to continue, feel free to reopen it or submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants