Benchmark and improve Nix NAR unpacking - #6
Draft
siraben wants to merge 9 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paths/statsrows are overlaid for reads and flushed to SQLite in bulk.fsetattr, and lower the direct-I/O threshold used by the measured candidate.Benchmark
Fixture:
RESTORES_PER_RUN=5 RUNS=5 WARMUPS=1 python3 benchmarks/nix_unpack/run.pyThe post-run persistence smoke test confirmed 3256 restored paths and 3256 matching stat rows were flushed to
meta.db.Rejected experiments are documented in
benchmarks/nix_unpack/README.md.Validation
python3 -m py_compile benchmarks/nix_unpack/prepare.py benchmarks/nix_unpack/run.pyninja -C build-perf-rv64 ishmeson test -C build-bench-rv64 rvinterp-selftest rvdecode-selftestsqlite3 meta.dbcounts for restored paths/stats both returned3256