Fix relative URL resolution in HTML page reports#4609
Open
davidarny wants to merge 2 commits intositespeedio:mainfrom
Open
Fix relative URL resolution in HTML page reports#4609davidarny wants to merge 2 commits intositespeedio:mainfrom
davidarny wants to merge 2 commits intositespeedio:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42ed39b46b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix relative URL resolution in generated HTML page reports by adding a
<base>tag for per-page summary/run pages.This makes page reports work whether they are opened as:
/pages/example_com/path/pages/example_com/path//pages/example_com/path/index.htmlWithout this, relative URLs like
data/browsertime.har.gzanddata/screenshots/...can resolve to the wrong parent path when the page is opened without a trailing slash.Problem
Generated page report HTML uses relative paths such as:
data/browsertime.har.gzdata/screenshots/..../1.htmlmetrics.htmlWhen a report page is opened at a slashless directory URL, the browser resolves those relative paths against the parent path, which can produce 404s for the HAR and screenshots. The waterfall then stays loading forever because the fetch/decompression never succeeds.
Fix
baseHrefsupport in the shared HTML layout template.baseHreffor URL summary and URL run pages fromhtmlBuilder.js.The computed base href points to the generated page directory, so all existing relative URLs continue to work correctly.
Related
Fixes #4608