Conversation
badrogger
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the settings management in
node_cli/utils/settings.py, focusing on ensuring data validity and preventing stale settings files. The main changes involve validating settings before saving and removing existing settings files to avoid conflicts.Validation and file management improvements:
model_validatefor both node and internal settings to ensure data correctness before saving. (Fa2a4858L51R51, Fa2a4858L82R82)_remove_if_existshelper function to safely delete existing settings files (NODE_SETTINGS_PATHandINTERNAL_SETTINGS_PATH) before writing new ones, preventing stale or conflicting data. (node_cli/utils/settings.pyR21, Fa2a4858L51R51, Fa2a4858L82R82)These changes help maintain the integrity of settings files and improve reliability in configuration handling.