fix: make dex optional on the clearinghouseState subscription - #8
Open
camelpunch wants to merge 1 commit into
Open
fix: make dex optional on the clearinghouseState subscription#8camelpunch wants to merge 1 commit into
camelpunch wants to merge 1 commit into
Conversation
validate_required treated dex as always missing whenever it was set to "", the documented default for the main perps market used everywhere else in the package (Info.ClearinghouseState, meta, metaAndAssetCtxs, perpDexStatus). That made it impossible to subscribe to the main market's clearinghouse state at all. dex is now optional, defaulting to "" like its Info sibling, while a named builder-deployed dex can still be passed explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another possible bug found by Claude. I want to automate a vault, which is on the first perp dex, which is "" according to the docs (example). Slop:
validate_required treated dex as always missing whenever it was set to "", the documented default for the main perps market used everywhere else in the package (Info.ClearinghouseState, meta, metaAndAssetCtxs, perpDexStatus). That made it impossible to subscribe to the main market's clearinghouse state at all. dex is now optional, defaulting to "" like its Info sibling, while a named builder-deployed dex can still be passed explicitly.