Skip to content

Test tags #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dfabulich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Test tags #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af6275f
Add test tag to TabView
dfabulich Mar 30, 2026
971c86f
Add test tag to SearchField
dfabulich Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/SkipUI/SkipUI/Commands/Search.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ import androidx.compose.ui.input.nestedscroll.NestedScrollConnection
import androidx.compose.ui.input.nestedscroll.NestedScrollSource
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.platform.LocalFocusManager
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTagsAsResourceId
import androidx.compose.ui.text.input.ImeAction
import androidx.compose.ui.unit.dp
import kotlinx.coroutines.launch
Expand Down Expand Up @@ -130,7 +133,7 @@ let searchFieldHeight = 56.0
let isFocused = remember { mutableStateOf(false) }
OutlinedTextField(value: state.text.wrappedValue, onValueChange: {
state.text.wrappedValue = $0
}, modifier: Modifier.weight(Float(1.0)).focusRequester(focusRequester).onFocusChanged {
}, modifier: Modifier.weight(Float(1.0)).semantics { testTagsAsResourceId = true }.testTag("skip_ui_automation_search_field").focusRequester(focusRequester).onFocusChanged {
if $0.isFocused {
state.isSearching.value = true
}
Expand Down
6 changes: 5 additions & 1 deletion Sources/SkipUI/SkipUI/Containers/TabView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ import androidx.compose.ui.graphics.graphicsLayer
import androidx.compose.ui.geometry.Rect
import androidx.compose.ui.layout.boundsInWindow
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.platform.testTag
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.testTagsAsResourceId
import androidx.compose.ui.unit.Dp
import androidx.compose.ui.unit.dp
import androidx.navigation.NavHostController
Expand Down Expand Up @@ -257,6 +260,7 @@ public struct TabView : View, Renderable {
bottomBarTopPx.value = bounds.top
bottomBarHeightPx.value = bounds.bottom - bounds.top
}
.semantics { testTagsAsResourceId = true }.testTag("skip_ui_automation_tab_bar")
let tint = EnvironmentValues.shared._tint
let hasColorScheme = reducedTabBarPreferences.colorScheme != nil
let isSystemBackground = reducedTabBarPreferences.isSystemBackground == true
Expand Down Expand Up @@ -336,7 +340,7 @@ public struct TabView : View, Renderable {
if let updateOptions = EnvironmentValues.shared._material3NavigationBar {
options = updateOptions(options)
}
NavigationBar(modifier: options.modifier, containerColor: options.containerColor, contentColor: options.contentColor, tonalElevation: options.tonalElevation) {
NavigationBar(modifier: options.modifier.semantics { testTagsAsResourceId = true }.testTag("skip_ui_automation_tab_bar"), containerColor: options.containerColor, contentColor: options.contentColor, tonalElevation: options.tonalElevation) {
for tabIndex in 0..<tabRenderables.size {
if tabs[tabIndex]?.isHidden == true {
continue
Expand Down
Loading