Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Helm release storage retains chart metadata but not reliable original chart-source provenance. After restart, moving Radar between machines, or for older releases, Radar can therefore lose the repository/OCI source required to reconstruct the exact installed chart.
This is especially important for safe Values Preview/Apply because complete chart reconstruction must not depend on machine-local repository aliases.
Fix
Safety
Tests
go test ./internal/helm -count=1Dependency
Depends on #1631, which provides the fail-closed complete-chart reconstruction used by this recovery path.